Pre-generate updates for test harness in parallel.

Pre-generate updates for test harness in parallel.

First CL of many.  Thought I'd commit this before the others since 
it sets stuff up for the other CL's (i.e. Thread Pool).

With this CL, all updates will be pre-generated before the test run.
This should improve some speeds since the two updates will be produced
at the same time rather than at the time of the sequential tests.

Change-Id: Iaf0a06f0d99c31d3d749e478fd2fb6efa0763a28

BUG=chromium-os:10723
TEST=Ran it with -q

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a4cc3cd

[sosa, 2011-01-19 22:59:42]

PTAL some fixes for detcing the VM image and fixed a bug in UpdateWithFilter

[dgarrett, 2011-01-20 03:34:27]

LGTM, with a few nits.

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:137: except Exception as err:
After reading this again, the new exception handler shouldn't be added, the
warning messages (and perhaps a new fail message) should just be in an else
clause for the above if.

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:508: self._first_update = True
A comment explaining the purpose of _first_image would probably be really
helpful. Or perhaps renaming it to a name related to qemu, somehow.

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:520: '--test_image'], enter_chroot=True)
arguments should be indented to match the open [.

[sosa, 2011-01-20 03:59:49]

Is this what you meant by the else?

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:137: except Exception as err:
On 2011/01/20 03:34:27, dgarrett wrote:
> After reading this again, the new exception handler shouldn't be added, the
> warning messages (and perhaps a new fail message) should just be in an else
> clause for the above if.

Done.

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:508: self._first_update = True
On 2011/01/20 03:34:27, dgarrett wrote:
> A comment explaining the purpose of _first_image would probably be really
> helpful. Or perhaps renaming it to a name related to qemu, somehow.

Done.

http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:520: '--test_image'], enter_chroot=True)
On 2011/01/20 03:34:27, dgarrett wrote:
> arguments should be indented to match the open [.

Done.

[dgarrett, 2011-01-20 04:20:16]

Yep.

LGTM!

On Wed, Jan 19, 2011 at 7:59 PM, <sosa@chromium.org> wrote:

> Is this what you meant by the else?
>
>
>
>
> http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py
> File bin/cros_au_test_harness.py (right):
>
>
>
http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
> bin/cros_au_test_harness.py:137: except Exception as err:
> On 2011/01/20 03:34:27, dgarrett wrote:
>
>> After reading this again, the new exception handler shouldn't be
>>
> added, the
>
>> warning messages (and perhaps a new fail message) should just be in an
>>
> else
>
>> clause for the above if.
>>
>
> Done.
>
>
>
>
http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
> bin/cros_au_test_harness.py:508: self._first_update = True
> On 2011/01/20 03:34:27, dgarrett wrote:
>
>> A comment explaining the purpose of _first_image would probably be
>>
> really
>
>> helpful. Or perhaps renaming it to a name related to qemu, somehow.
>>
>
> Done.
>
>
>
>
http://codereview.chromium.org/6264005/diff/12001/bin/cros_au_test_harness.py...
> bin/cros_au_test_harness.py:520: '--test_image'], enter_chroot=True)
> On 2011/01/20 03:34:27, dgarrett wrote:
>
>> arguments should be indented to match the open [.
>>
>
> Done.
>
>
> http://codereview.chromium.org/6264005/
>



-- 
Don