Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 6263014: Add Perceived PageLoad Time (PPLT) metrics for Prerender Experiments,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
===================================================================
--- chrome/browser/prerender/prerender_manager.cc (revision 72357)
+++ chrome/browser/prerender/prerender_manager.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/prerender/prerender_manager.h"
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/prerender/prerender_contents.h"
@@ -30,7 +31,8 @@
: profile_(profile),
max_prerender_age_(base::TimeDelta::FromSeconds(
kDefaultMaxPrerenderAgeSeconds)),
- max_elements_(kDefaultMaxPrerenderElements) {
+ max_elements_(kDefaultMaxPrerenderElements),
+ mode_(PRERENDER_MODE_ENABLED) {
}
PrerenderManager::~PrerenderManager() {
@@ -108,6 +110,9 @@
if (!title.empty())
tc->UpdateTitle(rvh, pc->page_id(), UTF16ToWideHack(title));
+ if (pc->has_stopped_loading())
+ tc->DidStopLoading();
+
return true;
}
@@ -139,3 +144,16 @@
const std::vector<GURL>& alias_urls) {
return new PrerenderContents(this, profile_, url, alias_urls);
}
+
+void PrerenderManager::RecordPerceivedPageLoadTime(base::TimeDelta pplt) {
+ switch(mode_) {
+ case PRERENDER_MODE_EXPERIMENT_CONTROL_GROUP:
+ UMA_HISTOGRAM_TIMES("PLT.PerceivedPageLoadTime_PrerenderControl", pplt);
+ break;
+ case PRERENDER_MODE_EXPERIMENT_PRERENDER_GROUP:
+ UMA_HISTOGRAM_TIMES("PLT.PerceivedPageLoadTime_PrerenderTreatment", pplt);
+ break;
+ default:
+ break;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698