Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 6263014: Add Perceived PageLoad Time (PPLT) metrics for Prerender Experiments,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents.cc (revision 72694)
+++ chrome/browser/tab_contents/tab_contents.cc (working copy)
@@ -52,6 +52,7 @@
#include "chrome/browser/plugin_installer_infobar_delegate.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prerender/prerender_manager.h"
+#include "chrome/browser/prerender/prerender_plt_recorder.h"
#include "chrome/browser/printing/print_preview_tab_controller.h"
#include "chrome/browser/printing/print_view_manager.h"
#include "chrome/browser/profiles/profile.h"
@@ -367,6 +368,7 @@
autocomplete_history_manager_(),
autofill_manager_(),
plugin_installer_(),
+ prerender_plt_recorder_(),
bookmark_drag_(NULL),
ALLOW_THIS_IN_INITIALIZER_LIST(fav_icon_helper_(this)),
is_loading_(false),
@@ -472,6 +474,8 @@
AddNavigationObserver(autofill_manager_.get());
autocomplete_history_manager_.reset(new AutocompleteHistoryManager(this));
AddNavigationObserver(autocomplete_history_manager_.get());
+ prerender_plt_recorder_.reset(new PrerenderPLTRecorder(this));
+ AddNavigationObserver(prerender_plt_recorder_.get());
AddNavigationObserver(&fav_icon_helper_);
AddNavigationObserver(printing_.get());
}
@@ -3393,12 +3397,8 @@
bool TabContents::MaybeUsePreloadedPage(const GURL& url) {
PrerenderManager* pm = profile()->GetPrerenderManager();
if (pm != NULL) {
- if (pm->MaybeUsePreloadedPage(this, url)) {
- // TODO(tburkard): If the preloaded page has not finished preloading
- // yet, we should not do this.
- DidStopLoading();
+ if (pm->MaybeUsePreloadedPage(this, url))
return true;
- }
}
return false;
}
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698