Add Perceived PageLoad Time (PPLT) metrics for Prerender Experiments,...

chrome/browser/prerender/prerender_manager.h

Index: chrome/browser/prerender/prerender_manager.h
===================================================================
--- chrome/browser/prerender/prerender_manager.h	(revision 72357)
+++ chrome/browser/prerender/prerender_manager.h	(working copy)
@@ -24,6 +24,13 @@
 class PrerenderManager : public base::RefCounted<PrerenderManager>,
                          private base::NonThreadSafe {
  public:
+  enum PrerenderManagerMode {
+    kDisabled,

[cbentzel, 2011/01/26 19:38:36]

Chrome style uses MACRO_MODE for enum values, despite what C++ style says.

[tburkard, 2011/01/26 20:05:50]

So what does that mean?  WHat do i have to change here?
On 2011/01/26 19:38:36, cbentzel wrote:

[cbentzel, 2011/01/26 21:25:36]

Just name something like PRERENDER_MODE_DISABLED

+    kEnabled,
+    kExperimentControlGroup,
+    kExperimentPrerenderGroup
+  };
+
   // Owned by a Profile object for the lifetime of the profile.
   explicit PrerenderManager(Profile* profile);
 
@@ -51,6 +58,7 @@
   void set_max_prerender_age(base::TimeDelta td) { max_prerender_age_ = td; }
   unsigned int max_elements() const { return max_elements_; }
   void set_max_elements(unsigned int num) { max_elements_ = num; }
+  PrerenderManagerMode mode() { return mode_; }

[cbentzel, 2011/01/26 19:38:36]

const

I still think this might not be needed if the histogramming is done with the
PrerenderManager. 

[tburkard, 2011/01/26 20:05:50]

Done.

 
  protected:
   virtual ~PrerenderManager();
@@ -80,6 +88,8 @@
   // Default maximum age a prerendered element may have, in seconds.
   static const int kDefaultMaxPrerenderAgeSeconds = 20;
 
+  PrerenderManagerMode mode_;
+
   DISALLOW_COPY_AND_ASSIGN(PrerenderManager);
 };