Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 6263010: More net/ header/implementation method reordering. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

More net/ header/implementation method reordering. (Contains some minor de-inlining.) BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72232

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+957 lines, -922 lines) Patch
M net/disk_cache/bitmap.h View 2 chunks +4 lines, -22 lines 2 comments Download
M net/disk_cache/bitmap.cc View 4 chunks +45 lines, -18 lines 0 comments Download
M net/disk_cache/block_files.cc View 3 chunks +85 lines, -85 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 2 chunks +5 lines, -7 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 4 chunks +106 lines, -87 lines 0 comments Download
M net/disk_cache/mem_entry_impl.h View 2 chunks +22 lines, -22 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 3 chunks +81 lines, -79 lines 0 comments Download
M net/disk_cache/stats_histogram.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 3 chunks +8 lines, -7 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 3 chunks +24 lines, -24 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 7 chunks +47 lines, -46 lines 0 comments Download
M net/socket_stream/socket_stream_metrics.h View 2 chunks +14 lines, -13 lines 0 comments Download
M net/spdy/spdy_framer.cc View 10 chunks +508 lines, -504 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
More rubberstampable physical code reorganizations.
9 years, 11 months ago (2011-01-21 23:02:33 UTC) #1
willchan no longer on Chromium
LGTM http://codereview.chromium.org/6263010/diff/1/net/disk_cache/bitmap.h File net/disk_cache/bitmap.h (right): http://codereview.chromium.org/6263010/diff/1/net/disk_cache/bitmap.h#newcode16 net/disk_cache/bitmap.h:16: Bitmap() : map_(NULL), num_bits_(0), array_size_(0), alloc_(false) {} I'm ...
9 years, 11 months ago (2011-01-21 23:07:32 UTC) #2
Elliot Glaysher
9 years, 11 months ago (2011-01-21 23:11:15 UTC) #3
http://codereview.chromium.org/6263010/diff/1/net/disk_cache/bitmap.h
File net/disk_cache/bitmap.h (right):

http://codereview.chromium.org/6263010/diff/1/net/disk_cache/bitmap.h#newcode16
net/disk_cache/bitmap.h:16: Bitmap() : map_(NULL), num_bits_(0), array_size_(0),
alloc_(false) {}
On 2011/01/21 23:07:33, willchan wrote:
> I'm a bit surprised you didn't define this out of line too. I guess it's
small.

Yeah; the other ctors called multiple methods and required <algorithm> in the
header. This one is comparably small and just does four integral assignments.

Powered by Google App Engine
This is Rietveld 408576698