Issue 6263009: lastchange.py: fix style, unify git codepath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6263009: lastchange.py: fix style, unify git codepath (Closed)

Created:
9 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

lastchange.py: fix style, unify git codepath 1) Change style to match style guide. 2) Use "git svn info" so we can use the same parsing code for both git and svn. TEST=ran manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72074

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : fix #

Patch Set 4 : ok #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -41 lines)			Patch
	M	build/util/lastchange.py	View	1 2 3	3 chunks	+15 lines, -41 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages