Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 6263006: Modify licenses.py to handle Windows paths and support all DEPS.... (Closed)

Created:
9 years, 11 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org
Visibility:
Public.

Description

Modify licenses.py to handle Windows paths and support all DEPS. Also bring about_credits.html up to date. 1. licenses.py was failing on Windows because of path separators, so I changed remaining path strings to use os.path.join. 2. I wasn't seeing all DEPS on my system, so I modified DEPS locally to ignore os_deps. That led to several changes to make sure os-specific libraries (pdfsqueeze, GTM, for example) get attribution in about_credits. 3. Some of the code we pull in doesn't need attribution in our about_credits (windows SDK), so I added new ignore rules. BUG=none TEST= dunno. about:credits credits everything we include? R= evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71570

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1816 lines, -20 lines) Patch
M chrome/browser/resources/about_credits.html View 15 chunks +1772 lines, -5 lines 0 comments Download
M tools/licenses.py View 1 3 chunks +44 lines, -15 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Mark Larson
9 years, 11 months ago (2011-01-16 04:42:24 UTC) #1
Mark Larson
9 years, 11 months ago (2011-01-16 04:46:27 UTC) #2
evanm
9 years, 11 months ago (2011-01-16 18:26:27 UTC) #3
LGTM

http://codereview.chromium.org/6263006/diff/3001/tools/licenses.py
File tools/licenses.py (right):

http://codereview.chromium.org/6263006/diff/3001/tools/licenses.py#newcode67
tools/licenses.py:67: # ---- in DEPS.
Don't forget to follow up on this (I don't quite understand the comment) --
perhaps file a bug?

http://codereview.chromium.org/6263006/diff/3001/tools/licenses.py#newcode128
tools/licenses.py:128: # pdfsqueeze is Apache Licensed, reuse the same file from
GTM:
I'm not sure in this case, but some licenses require you include their
copyrights (which will list different authors, even when the body of the license
is the same).

Powered by Google App Engine
This is Rietveld 408576698