Issue 6263001: Expose receiver check type in call type feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6263001: Expose receiver check type in call type feedback. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Expose receiver check type in call type feedback. This a preparatory step to support fast function calls on primitive values. Not really used yet in hydrogen. Committed: http://code.google.com/p/v8/source/detail?r=6300

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -26 lines)			Patch
M	src/ast.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+13 lines, -4 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	src/type-info.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View	8 chunks	+51 lines, -16 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/6263001/diff/1/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/6263001/diff/1/src/type-info.cc#newcode81 src/type-info.cc:81: return IsMonomorphic(expr->position()); It seems that the private helper ...

9 years, 11 months ago (2011-01-13 13:44:50 UTC) #2

Vitaly Repeshko

9 years, 11 months ago (2011-01-13 14:16:54 UTC) #3

http://codereview.chromium.org/6263001/diff/1/src/type-info.cc
File src/type-info.cc (right):

http://codereview.chromium.org/6263001/diff/1/src/type-info.cc#newcode81
src/type-info.cc:81: return IsMonomorphic(expr->position());
On 2011/01/13 13:44:50, fschneider wrote:
> It seems that the private helper IsMonomorphic is not very useful anymore.
Maybe
> just copy it into here and into LoadIsMonomorphic above.

Done.

Expand Messages | Collapse Messages