Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 6262018: Cleanup:... (Closed)

Created:
9 years, 11 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, James Hawkins, brettw-cc_chromium.org, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Cleanup: * Remove AlertInfoBarDelegate. There are basically no users of this (the only one is in autofill which is really trying to make something like a confirm info bar). * Change the default button set for a ConfirmInfoBarDelegate from 0 buttons to 2 to match how practically every caller uses it. Note that this doesn't remove views' AlertInfoBar yet. AlertInfoBar is now only used as a base for ConfirmInfoBar, but actually moving that functionality into ConfirmInfoBar is to come in a subsequent patch. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72726

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -354 lines) Patch
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_win.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager_delegate_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 8 chunks +12 lines, -30 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.cc View 7 chunks +16 lines, -29 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 2 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm View 4 chunks +21 lines, -56 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_test_helper.h View 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_test_helper.mm View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/infobar_gtk.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/infobar_gtk.cc View 4 chunks +4 lines, -52 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobars.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobars.cc View 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
9 years, 11 months ago (2011-01-26 20:33:54 UTC) #1
Elliot Glaysher
Patch LGTM. Surprised about everyone reimplementing GetButtons(). Otherwise +1 to simplification. http://codereview.chromium.org/6262018/diff/1/chrome/browser/tab_contents/infobar_delegate.cc File chrome/browser/tab_contents/infobar_delegate.cc (right): ...
9 years, 11 months ago (2011-01-26 20:52:22 UTC) #2
Peter Kasting
9 years, 11 months ago (2011-01-26 20:55:59 UTC) #3
http://codereview.chromium.org/6262018/diff/1/chrome/browser/tab_contents/inf...
File chrome/browser/tab_contents/infobar_delegate.cc (right):

http://codereview.chromium.org/6262018/diff/1/chrome/browser/tab_contents/inf...
chrome/browser/tab_contents/infobar_delegate.cc:191: }
On 2011/01/26 20:52:22, Elliot Glaysher wrote:
> Linter wants newline

It has a newline.  The linter is wrong about this 98% of the time.  I don't know
why.

Powered by Google App Engine
This is Rietveld 408576698