Refactor the first-read logic for the in-mem server....

A few cleanups in the in-mem flip server:
  * Refactor the first-read logic for the in-mem server.
    Split out functions from the initial connection setup on first read.
  * Fixed the SPDY-only (non-NPN negotiated) case.
  * Hardened the server against invalid protocol attacks; would happily
    crash when an invalid-looking frame arrived.

BUG=none
TEST=self


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72536

[kelindsay, 2011-01-25 19:00:28]

Just one comment...

http://codereview.chromium.org/6262014/diff/10001/net/tools/flip_server/flip_...
File net/tools/flip_server/flip_in_mem_edsm_server.cc (right):

http://codereview.chromium.org/6262014/diff/10001/net/tools/flip_server/flip_...
net/tools/flip_server/flip_in_mem_edsm_server.cc:1160: DCHECK(spdy_negotiated); 
// This is only a SPDY->SPDY proxy.
FLIP_HANDLER_PROXY indicates that we can accept both https and spdy connections.
The logic we want here is to set sm_interface_ to sm_spdy_interface_ if
spdy_negotiated is true otherwise we set it to sm_streamer_interface_ . It is
acceptable for spdy_negotiated to be false at this point.

so I think what we want here is an if (!spdy_negotiated) { ...; break; } around
this case otherwise fall through to setup the spdy interface.

Thanks for cleaning this up!

[mbelshe, 2011-01-25 19:14:08]

Thanks - changed to support SSL through the proxy.  Let me know if it looks
ok.

Mike


On Tue, Jan 25, 2011 at 11:00 AM, <kelindsay@gmail.com> wrote:

> Just one comment...
>
>
>
>
http://codereview.chromium.org/6262014/diff/10001/net/tools/flip_server/flip_...
> File net/tools/flip_server/flip_in_mem_edsm_server.cc (right):
>
>
>
http://codereview.chromium.org/6262014/diff/10001/net/tools/flip_server/flip_...
> net/tools/flip_server/flip_in_mem_edsm_server.cc:1160:
> DCHECK(spdy_negotiated);  // This is only a SPDY->SPDY proxy.
> FLIP_HANDLER_PROXY indicates that we can accept both https and spdy
> connections. The logic we want here is to set sm_interface_ to
> sm_spdy_interface_ if spdy_negotiated is true otherwise we set it to
> sm_streamer_interface_ . It is acceptable for spdy_negotiated to be
> false at this point.
>
> so I think what we want here is an if (!spdy_negotiated) { ...; break; }
> around this case otherwise fall through to setup the spdy interface.
>
> Thanks for cleaning this up!
>
>
> http://codereview.chromium.org/6262014/
>

[kelindsay, 2011-01-25 19:39:54]

LGTM