Issue 6262013: X64 Crankshaft: Added some functions needed for delta-blue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6262013: X64 Crankshaft: Added some functions needed for delta-blue. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse, Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build-x64

Visibility:
Public.

Description

X64 Crankshaft: Added some functions needed for delta-blue. Committed: http://code.google.com/p/v8/source/detail?r=6468

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -17 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		5 chunks	+52 lines, -5 lines	2 comments	Download
	M	src/x64/lithium-x64.cc	View		6 chunks	+18 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc#newcode1486 src/x64/lithium-codegen-x64.cc:1486: ASSERT(!argument->IsDoubleRegister()); Don't we have more of a problem ...

9 years, 11 months ago (2011-01-25 13:55:07 UTC) #2

Lasse Reichstein

9 years, 11 months ago (2011-01-25 14:01:11 UTC) #3

http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1486: ASSERT(!argument->IsDoubleRegister());
I don't think it can happen (from reading the ia32 code, where they just make an
Operand in all non-constant cases).

Expand Messages | Collapse Messages