Issue 6262012: Remove multiple inheritance from input_method_menu_button.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6262012: Remove multiple inheritance from input_method_menu_button.h. (Closed)

Created:
9 years, 11 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove multiple inheritance from input_method_menu_button.h. Currently chromeos::InputMethodMenuButton is derived from both StatusAreaButton and InputMethodMenu, which violates the Chrome coding guideline. This change removes the multiple inheritance by adding InputMethodMenu object to InputMethodMenuButton as a member variable. BUG=chromium-os:7572 TEST=manually & try bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72467

Patch Set 1 : review #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -15 lines)			Patch
M	chrome/browser/chromeos/login/keyboard_switch_menu.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/keyboard_switch_menu.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu_button.h	View	4 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu_button.cc	View	5 chunks	+40 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages