Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 6262010: Revert 72225 - This patch moves the experiments settings from the user profil... (Closed)

Created:
9 years, 11 months ago by rniwa-cr
Modified:
9 years, 6 months ago
Reviewers:
bbudge-google
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 72225 - This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. This is a release blocker for NaCl, so we decided to push this through. Windows browser tests are failing. TEST=manual BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322 Review URL: http://codereview.chromium.org/6267009 TBR=bbudge@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/browser_main.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/dom_ui/flags_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/flags_ui.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
9 years, 11 months ago (2011-01-22 05:53:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698