Issue 6262005: Merge changes to LTemplateInstruction to X64 (Issue 1048).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6262005: Merge changes to LTemplateInstruction to X64 (Issue 1048). (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
fschneider, Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build-x64

Visibility:
Public.

Description

Merge changes to LTemplateInstruction to X64 (Issue 1048). Implement ConstantD and ConstantI. BUG=1048 Committed: http://code.google.com/p/v8/source/detail?r=6352

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+560 lines, -616 lines)			Patch
M	src/hydrogen-instructions.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+21 lines, -23 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	38 chunks	+498 lines, -567 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	9 chunks	+39 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 11 months ago (2011-01-17 13:46:17 UTC) #2

LGTM, but since we do not have any test coverage of the DoConstant* yet it is
hard to tell if this is actually working as intended(since be basically deopt on
everything right now)

Expand Messages | Collapse Messages