Issue 6262: Improve performance of arguments object allocation by taking...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6262: Improve performance of arguments object allocation by taking... (Closed)

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve performance of arguments object allocation by taking care of arguments adaptor frames in the generated code. Committed: http://code.google.com/p/v8/source/detail?r=434

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -87 lines)			Patch
M	src/codegen.h	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View	9 chunks	+41 lines, -43 lines	1 comment	Download
M	src/codegen-ia32.cc	View	9 chunks	+40 lines, -44 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	test/mjsunit/fuzz-natives.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

http://codereview.chromium.org/6262/diff/1/6 File src/codegen-arm.cc (right): http://codereview.chromium.org/6262/diff/1/6#newcode592 Line 592: __ add(r1, fp, Operand((2 + scope->num_parameters()) * kPointerSize)); ...

12 years, 2 months ago (2008-10-06 06:05:59 UTC) #2

And LGTM by the way. :-)

Expand Messages | Collapse Messages