Make a hole only as big as is necessary.

Make a hole only as big as is necessary.

Compute the rectangle for the paint, and create a hole inside it, instead of
making a giant all-consuming hole.

BUG=70410
TEST=manually, see bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72156

[sadrul, 2011-01-21 15:56:52]

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:362: return;
I do not know if painting the hole is necessary here?

[Alex Nicolaou, 2011-01-21 16:00:16]

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:362: return;
On 2011/01/21 15:56:53, sadrul wrote:
> I do not know if painting the hole is necessary here?

Yes it is, that's why it was above this point. Otherwise you're in a race with
the GPU process.

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:390:
SkXfermode::kClear_Mode);
You'll have to move this back up.

If you're really worried about it, it would also be great to address the TODO on
line 370 which is 99% of the inefficiency here.

[tfarina, 2011-01-21 16:31:52]

Can you put the bug number in the BUG= line instead of a description?

[sadrul, 2011-01-21 16:36:19]

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/6261019/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:390:
SkXfermode::kClear_Mode);
On 2011/01/21 16:00:16, Alex Nicolaou wrote:
> You'll have to move this back up.
> 
> If you're really worried about it, it would also be great to address the TODO
on
> line 370 which is 99% of the inefficiency here.

Moved this back up.

http://codereview.chromium.org/6261019/diff/5001/chrome/browser/renderer_host...
chrome/browser/renderer_host/render_widget_host_view_views.cc:285: }
We need to either sanitize invalid_rect_ here, or sanitize paint_rect in ~390.

[sadrul, 2011-01-21 16:44:30]

On 2011/01/21 16:31:52, tfarina wrote:
> Can you put the bug number in the BUG= line instead of a description?

Done!

[Alex Nicolaou, 2011-01-21 17:51:36]

LGTM