Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 6261018: Return the empty string when formatting recursive error messages. This (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Return the empty string when formatting recursive error messages. This matches the behavior of Safari and Firefox. Our old behavior was to throw a stack overflow exception. BUG=crbug.com/70334 TEST=mjsunit/cyclic-error-to-string.js Committed: http://code.google.com/p/v8/source/detail?r=6428

Patch Set 1 #

Patch Set 2 : Fix long line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -6 lines) Patch
M src/messages.js View 1 1 chunk +34 lines, -6 lines 0 comments Download
A test/mjsunit/cyclic-error-to-string.js View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-21 11:36:09 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-21 11:43:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698