Issue 6261017: Dynamically check types of PPAPI IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6261017: Dynamically check types of PPAPI IDs (Closed)

Created:
9 years, 11 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Dynamically check types of PPAPI IDs BUG=none TEST=Pepper Flash, PPAPITests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71985

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -11 lines)			Patch
	M	webkit/plugins/ppapi/resource_tracker.cc	View		14 chunks	+59 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

9 years, 11 months ago (2011-01-20 05:45:09 UTC) #2

LGTM

http://codereview.chromium.org/6261017/diff/1/webkit/plugins/ppapi/resource_t...
File webkit/plugins/ppapi/resource_tracker.cc (right):

http://codereview.chromium.org/6261017/diff/1/webkit/plugins/ppapi/resource_t...
webkit/plugins/ppapi/resource_tracker.cc:79:
std::numeric_limits<PP_Resource>::max() >> kPPIdTypeBits)
Can you add parens here to clarify the order of operations?

Expand Messages | Collapse Messages