Keep visibility state in sync between the native window and view

Keep visibility state in sync between the native window and view

Native ConstrainedWindows are invisible upon creation on Windows.  Mark the
associated NonClientView as hidden to keep the visibility state in sync.

BUG=69673
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71999

[asanka (google), 2011-01-19 18:41:36]

For review.

zel: Added for revision 36415.

[cbentzel, 2011-01-19 20:56:52]

On 2011/01/19 18:41:36, asanka (google) wrote:
> For review.
> 
> zel: Added for revision 36415.

I don't know this area of code, but zel looks like a good reviewer.

[zel, 2011-01-19 21:28:53]

LGTM 

but it's been a while since I touched windows views, sky@ might be a better
choice here

[sky, 2011-01-19 21:36:51]

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
File chrome/browser/ui/views/constrained_window_win.cc (right):

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
chrome/browser/ui/views/constrained_window_win.cc:574:
GetNonClientView()->SetVisible(true);
Add a comment as to why this is necessary.

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
chrome/browser/ui/views/constrained_window_win.cc:618:
GetNonClientView()->SetVisible(false);
Add a comment as to why this is necessary.

[asanka (google), 2011-01-20 14:49:17]

Thanks for the reviews.  I've added comments explaining why it's necessary to
set visibility.

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
File chrome/browser/ui/views/constrained_window_win.cc (right):

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
chrome/browser/ui/views/constrained_window_win.cc:574:
GetNonClientView()->SetVisible(true);
On 2011/01/19 21:36:51, sky wrote:
> Add a comment as to why this is necessary.

Done.

http://codereview.chromium.org/6261015/diff/1/chrome/browser/ui/views/constra...
chrome/browser/ui/views/constrained_window_win.cc:618:
GetNonClientView()->SetVisible(false);
On 2011/01/19 21:36:51, sky wrote:
> Add a comment as to why this is necessary.

Done.

[sky, 2011-01-20 16:58:34]

LGTM