Issue 6261009: Tests for setting break points by script id and position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6261009: Tests for setting break points by script id and position. (Closed)

Created:
9 years, 11 months ago by podivilov

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Tests for setting break points by script id and position. Committed: http://code.google.com/p/v8/source/detail?r=6314

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -0 lines)			Patch
	M	test/mjsunit/debug-breakpoints.js	View		1 chunk	+86 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-14 11:20:05 UTC) #2

LGTM

http://codereview.chromium.org/6261009/diff/1/test/mjsunit/debug-breakpoints.js
File test/mjsunit/debug-breakpoints.js (right):

http://codereview.chromium.org/6261009/diff/1/test/mjsunit/debug-breakpoints....
test/mjsunit/debug-breakpoints.js:126: var break_point =
Debug.setBreakPointByScriptIdAndPosition(
Only 2 char indent.

Expand Messages | Collapse Messages