Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 6261003: crosutils/make_factory_package.sh: support full SSD image as target outside chroot (Closed)

Created:
9 years, 11 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils/make_factory_package.sh: support full SSD image as target outside chroot When running outside chroot, we should use locate_cgpt + "$GPT" to invoke cgpt; otherwise it may be not in system PATH. For dealing with a true SSD image (over USB, for example) this CL also improved data writing speed from <2M/s to 8M/s+ (over USB). BUG=chromium-os:10531 TEST=./make_factory_package.sh \ --factory=../build/images/x86-mario/latest/chromiumos_factory_image.bin \ --release=../build/images/x86-mario/latest//chromiumos_image.bin \ --diskimg=/dev/sdb Also tested: --diskimg=blah # local file (chroot) --diskimg=/dev/sdd (chroot) --diskimg=blah Change-Id: I647d97fe388f5b6a6223fa8cacfecdf00265f60c Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4653cbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M lib/cros_image_common.sh View 1 chunk +11 lines, -1 line 0 comments Download
M make_factory_package.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hung-Te
9 years, 11 months ago (2011-01-13 07:14:07 UTC) #1
Nick Sanders
lgtm. Please also test writing output to a file before submit. Please note whether inside/outside ...
9 years, 11 months ago (2011-01-13 08:35:32 UTC) #2
Nick Sanders
Can you also cherry pick these to 0.9.132.B?
9 years, 11 months ago (2011-01-13 08:55:54 UTC) #3
Hung-Te
9 years, 11 months ago (2011-01-14 03:20:43 UTC) #4
On 2011/01/13 08:55:54, Nick Sanders wrote:
> Can you also cherry pick these to 0.9.132.B?
Done.

Powered by Google App Engine
This is Rietveld 408576698