Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 626011: Vboot Reference: Add a RSA verify benchmark. (Closed)

Created:
10 years, 10 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Vboot Reference: Add a RSA verify benchmark. In addtion, add test cases and a script to generate them for benchmarking. Also fixes a path problem with the run_rsa_tests.sh script.

Patch Set 1 #

Patch Set 2 : Fix memory leak in case of intermediate error. #

Total comments: 1

Patch Set 3 : 80 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, --3 lines) Patch
M src/platform/vboot_reference/tests/Makefile View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
A src/platform/vboot_reference/tests/gen_test_cases.sh View 1 chunk +54 lines, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/rsa_verify_benchmark.c View 1 1 chunk +87 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/run_rsa_tests.sh View 1 chunk +5 lines, -3 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa1024_sha1.sig View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa1024_sha256.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa1024_sha512.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa2048_sha1.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa2048_sha256.sig View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa2048_sha512.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa4096_sha1.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa4096_sha256.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa4096_sha512.sig View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa8192_sha1.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa8192_sha256.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.rsa8192_sha512.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.sha1.digest View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.sha256.digest View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/testcases/test_file.sha512.digest View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
Once this is in too, I can add this and the SHA benchmarks to the ...
10 years, 10 months ago (2010-02-17 23:48:04 UTC) #1
petkov
10 years, 10 months ago (2010-02-18 00:26:41 UTC) #2
LGTM with one nit.

http://codereview.chromium.org/626011/diff/2001/42
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/626011/diff/2001/42#newcode10
src/platform/vboot_reference/tests/Makefile:10: LIBS =
$(TOP)/utils/firmware_image.o $(TOP)/crypto/libcrypto.a
$(TOP)/common/libcommon.a  \
80 chars

Powered by Google App Engine
This is Rietveld 408576698