Issue 6260057: Fix reentrancy in HandleInputEvent by posting a task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6260057: Fix reentrancy in HandleInputEvent by posting a task (Closed)

Created:
9 years, 10 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix reentrancy in HandleEvent by posting a task BUG=none TEST=pepper flash, run it and move the mouse everywhere. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73475

Patch Set 1 #

Patch Set 2 : fix compile errors #

Patch Set 3 : just set_unblock(false) #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	ppapi/proxy/ppp_instance_proxy.cc	View	1 2	1 chunk	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

Note: this only fixes the HandleInputEvent case, but I think the technique may be generally ...

9 years, 10 months ago (2011-02-01 05:06:04 UTC) #1

brettw

Were you going to replace this with setting the unblock flag to false?

9 years, 10 months ago (2011-02-01 18:56:31 UTC) #2

piman

On Tue, Feb 1, 2011 at 10:56 AM, <brettw@chromium.org> wrote: > Were you going to ...

9 years, 10 months ago (2011-02-02 02:30:50 UTC) #3

brettw

9 years, 10 months ago (2011-02-02 05:00:08 UTC) #4

LGTM

http://codereview.chromium.org/6260057/diff/4001/ppapi/proxy/ppp_instance_pro...
File ppapi/proxy/ppp_instance_proxy.cc (right):

http://codereview.chromium.org/6260057/diff/4001/ppapi/proxy/ppp_instance_pro...
ppapi/proxy/ppp_instance_proxy.cc:63: // plugin does a sync call to the
renderer.
Can you add something like: "This will force any synchronous calls from the
plugin to complete before processing this message. We avoid deadlock by never
"setting unblock" on messages from the plugin to the renderer."

Expand Messages | Collapse Messages