Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: functional/plugins.py

Issue 6260015: Fixing pyauto plugins test... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: functional/plugins.py
===================================================================
--- functional/plugins.py (revision 71987)
+++ functional/plugins.py (working copy)
@@ -192,19 +192,21 @@
# setting 1 min of wait time here.
test_utils.CallFunctionWithNewTimeout(self, 1 * 60 * 1000,
lambda: self.NavigateToURL('http://vimeo.com'))
- pid = self._GetPluginPID('Shockwave Flash')
- self.assertTrue(pid, msg='No plugin process for Shockwave Flash')
- self.Kill(pid)
+ # Wait until Shockwave Flash plugin process loads.
self.assertTrue(self.WaitUntil(
+ lambda: self._GetPluginPID('Shockwave Flash') is not None),
+ msg='No plugin process for Shockwave Flash')
+ self.Kill(self._GetPluginPID('Shockwave Flash'))
+ self.assertTrue(self.WaitUntil(
lambda: self._GetPluginPID('Shockwave Flash') is None),
msg='Expected Shockwave Flash plugin to die after killing')
- # Add an exception to block plugins on hulu.com.
+ # Add an exception to block plugins on vimeo.com.
self.SetPrefs(pyauto.kContentSettingsPatterns,
{'[*.]vimeo.com': {'plugins': 2}})
self.GetBrowserWindow(0).GetTab(0).Reload()
self.assertFalse(self._GetPluginPID('Shockwave Flash'),
- msg='Plug-in not blocked.')
+ msg='Shockwave Flash Plug-in not blocked.')
if __name__ == '__main__':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698