Issue 6260013: Delete unused strings, round 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6260013: Delete unused strings, round 1. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, TVL

CC:
chromium-reviews, finnur+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Delete unused strings, round 1. Delete strings from .grd files that are at least 6 months old and aren't used anywhere. BUG=none TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71857

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -236 lines)			Patch
	M	chrome/app/generated_resources.grd	View		34 chunks	+1 line, -168 lines	0 comments	Download
	M	chrome/app/resources/locale_settings.grd	View		5 chunks	+0 lines, -68 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

Rubber stamp LGTM if it passes the try bots. Did you try using chrome/tools/check_grd_for_unused_strings.py? It ...

9 years, 11 months ago (2011-01-19 21:39:58 UTC) #2

Evan Stade

9 years, 11 months ago (2011-01-19 21:54:53 UTC) #3

On 2011/01/19 21:39:58, tony wrote:
> Rubber stamp LGTM if it passes the try bots.
> 
> Did you try using chrome/tools/check_grd_for_unused_strings.py?  It should
help
> make this automated.

try runs:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/9359
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/11445
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/8909

I did not know of the existence of that script. I wrote my own bash script and
manually checked each one it told me was unused (because in some cases, people
intentionally inserted or left a string with the intent to use it later). I
didn't get through all of them yet though (hence round 1).

Expand Messages | Collapse Messages