Issue 6260012: Valgrind: Expand the PluginService leak suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6260012: Valgrind: Expand the PluginService leak suppression. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
cbentzel

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Valgrind: Expand the PluginService leak suppression. TBR=cbentzel BUG=70115 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71821

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cbentzel

9 years, 11 months ago (2011-01-19 19:20:30 UTC) #2

LGTM

I thought it was too tight, but I saw the same hash on a lot of the reports.

Thanks for widening it.

On Wed, Jan 19, 2011 at 2:17 PM, <jhawkins@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> Valgrind: Expand the PluginService leak suppression.
>
> TBR=cbentzel
> BUG=70115
> TEST=none
>
> Please review this at http://codereview.chromium.org/6260012/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
885554694009217e6ddd304c6b45339e79fb4132..0474552f6f3ed09d0d24b0af24590e300261d478
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3636,11 +3636,4 @@
>    fun:_ZN22DefaultSingletonTraitsI13PluginServiceE3NewEv
>    fun:_ZN9SingletonI13PluginService22DefaultSingletonTraitsIS0_ES0_E3getEv
>    fun:_ZN13PluginService11GetInstanceEv
> -   fun:_ZN18BrowserProcessImpl14CreateIOThreadEv
> -   fun:_ZN18BrowserProcessImpl9io_threadEv
> -
>
fun:_ZN59_GLOBAL__N_chrome_browser_browser_main.cc_00000000_7C6A03C718CreateChildThreadsEP18BrowserProcessImpl
> -   fun:_Z11BrowserMainRK18MainFunctionParams
> -
>
fun:_ZN54_GLOBAL__N_chrome_app_chrome_main.cc_00000000_3219A84B23RunNamedProcessTypeMainERKSsRK18MainFunctionParams
> -   fun:ChromeMain
> -   fun:main
>  }
>
>
>

Expand Messages | Collapse Messages