Issue 6260009: Handle two cases that we previously weren't expecting....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6260009: Handle two cases that we previously weren't expecting.... (Closed)

Created:
9 years, 11 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Handle two cases that we previously weren't expecting. The first is inside GCF where we get a tab message after the target tab has been torn down. Before, we set handled to 'false' which would cause the message to end up in AutomationProxy which doesn't know how to handle it. The fix is to drop the message and treat it as handled. The second is when we attempt to send a download request to the host browser but the request has already been terminated. We treated this as a fatal error, but now only log an error. TEST=See repro steps in bug. BUG=69595 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71805

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/automation/automation_resource_message_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome_frame/chrome_frame_automation.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages