Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 6260004: Refactor the GYP file for libjpeg-turbo.... (Closed)

Created:
9 years, 11 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Refactor the GYP file for libjpeg-turbo. This change cleans up the GYP file for libjpeg-turbo so we can directly build asm files in its 'libjpeg' target. (We can now do this because GYP Issue 102 is fixed.) Also, this change adds a 'RGBX_FILLER_OXFF' flag so libjpeg-turbo can produce the RGBA pixels compatible to Chrome/WebKit, i.e. we can remove the memory copy in gfx::JPEGCodec::Decode(). BUG=none TEST=build Chromium without errors when 'use_libjpeg_turbo' is 1. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -76 lines) Patch
M third_party/libjpeg_turbo/libjpeg.gyp View 10 chunks +11 lines, -76 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
9 years, 11 months ago (2011-01-14 08:31:17 UTC) #1
brettw
9 years, 11 months ago (2011-01-14 18:54:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698