Issue 6260003: Clear plugin data together with cookies on shutdown.

Issue 6260003: Clear plugin data together with cookies on shutdown. (Closed)

Created:
9 years, 11 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raghu Simha, ncarter (slow), arv (Not doing code reviews), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clear plugin data together with cookies on shutdown. BUG=58235 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71436

Patch Set 3 : update copyright date #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -14 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/options/content_settings_handler.h	View	1 2	4 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/options/content_settings_handler.cc	View	1 2	6 chunks	+19 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/options/options_util.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

Please review. This is pretty similar to http://codereview.chromium.org/6122008/. The interesting stuff is again in chrome/browser/dom_ui/options/content_settings_handler.* ...

9 years, 11 months ago (2011-01-13 17:46:15 UTC) #1

Evan Stade

lgtm w/question addressed http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/options/content_settings_handler.cc File chrome/browser/dom_ui/options/content_settings_handler.cc (right): http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/options/content_settings_handler.cc#newcode332 chrome/browser/dom_ui/options/content_settings_handler.cc:332: pref_change_registrar_.Add(prefs::kGeolocationContentSettings, this); need prefs::kClearPluginLSODataEnabled here? http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/options/content_settings_handler.h ...

9 years, 11 months ago (2011-01-13 19:31:51 UTC) #2

Bernhard Bauer

9 years, 11 months ago (2011-01-13 22:42:34 UTC) #3

On Thu, Jan 13, 2011 at 20:31,  <estade@chromium.org> wrote:
> lgtm w/question addressed
>
>
>
http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/option...
> File chrome/browser/dom_ui/options/content_settings_handler.cc (right):
>
>
http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/option...
> chrome/browser/dom_ui/options/content_settings_handler.cc:332:
> pref_change_registrar_.Add(prefs::kGeolocationContentSettings, this);
> need prefs::kClearPluginLSODataEnabled here?

clear_plugin_lso_data_enabled_ contains a BooleanPrefMember, which
does its own preference observing.

>
http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/option...
> File chrome/browser/dom_ui/options/content_settings_handler.h (right):
>
>
http://codereview.chromium.org/6260003/diff/2001/chrome/browser/dom_ui/option...
> chrome/browser/dom_ui/options/content_settings_handler.h:1: // Copyright
> (c) 2010 The Chromium Authors. All rights reserved.
> 2011
>
> http://codereview.chromium.org/6260003/
>

Expand Messages | Collapse Messages