Fix chromium-os:10777 and other sync related crashes.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 1230 matching lines @@
 
 TokenService* ProfileImpl::GetTokenService() {
   if (!token_service_.get()) {
     token_service_.reset(new TokenService());
   }
   return token_service_.get();
 }
 
 ProfileSyncService* ProfileImpl::GetProfileSyncService() {
 #if defined(OS_CHROMEOS)
-  // If kLoginManager is specified, we shouldn't call this unless login has

[akalin, 2011/01/13 04:15:02]

Hmm.  I'd rather callers explicitly check HasProfileSyncService(), since it
looks like there are only three places in the domui handler that needs that
change.  What do you think?

[stevenjb, 2011/01/13 18:00:49]

Originally I added checks in the settings code, but that does not address issue
10893 (we would need to remove the DCHECK there), and still leaves open the
possibility of other similar bugs, or more subtle ones where sync appears to be
enabled but the backend isn't initialized yet. Granted, these would only show up
for developers not running with kLoginManager, but even so I think it is better
not to set up sync in this place.

That said, I am fine with fixing the settings code and removing the DCHECK for
10893 if you and Tim prefer that.

-  // completed and specified cros_user. Guard with if (HasProfileSyncService())
-  // where this might legitimately get called before login has completed.
-  if (!sync_service_.get() &&
-      CommandLine::ForCurrentProcess()->HasSwitch(switches::kLoginManager)) {
-    LOG(FATAL) << "GetProfileSyncService() called before login complete.";
+  if (!sync_service_.get()) {
+    // In ChromeOS, we only want to initialize sync services explicitly from
+    // the login code. Use HasProfileSyncService() to guard against this.
+    return NULL;
   }
 #endif
   return GetProfileSyncService("");
 }
 
 ProfileSyncService* ProfileImpl::GetProfileSyncService(
     const std::string& cros_user) {
 
   if (!ProfileSyncService::IsSyncEnabled())
     return NULL;
@@ skipping 97 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_)
     prerender_manager_ = new PrerenderManager(this);
   return prerender_manager_;
 }