chrome/browser/browser_commands_unittest.cc - Issue 6260001: Cleanup: Remove unneeded chrome/browser/ui/browser.h usage....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/browser_commands_unittest.cc

Issue 6260001: Cleanup: Remove unneeded chrome/browser/ui/browser.h usage.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | chrome/browser/bug_report_data.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/app/chrome_command_ids.h"	5 #include "chrome/app/chrome_command_ids.h"

6 #include "chrome/browser/bookmarks/bookmark_model.h"	6 #include "chrome/browser/bookmarks/bookmark_model.h"

7 #include "chrome/browser/browser_thread.h"	7 #include "chrome/browser/browser_thread.h"

8 #include "chrome/browser/tab_contents/navigation_controller.h"	8 #include "chrome/browser/tab_contents/navigation_controller.h"

9 #include "chrome/browser/tab_contents/navigation_entry.h"	9 #include "chrome/browser/tab_contents/navigation_entry.h"

10 #include "chrome/browser/tab_contents/tab_contents.h"	10 #include "chrome/browser/tab_contents/tab_contents.h"

11 #include "chrome/browser/ui/browser.h"

12 #include "chrome/browser/ui/browser_list.h"	11 #include "chrome/browser/ui/browser_list.h"

13 #include "chrome/common/url_constants.h"	12 #include "chrome/common/url_constants.h"

14 #include "chrome/test/browser_with_test_window_test.h"	13 #include "chrome/test/browser_with_test_window_test.h"

15 #include "chrome/test/testing_profile.h"	14 #include "chrome/test/testing_profile.h"

16	15

17 typedef BrowserWithTestWindowTest BrowserCommandsTest;	16 typedef BrowserWithTestWindowTest BrowserCommandsTest;

18	17

19 // Tests IDC_SELECT_TAB_0, IDC_SELECT_NEXT_TAB, IDC_SELECT_PREVIOUS_TAB and	18 // Tests IDC_SELECT_TAB_0, IDC_SELECT_NEXT_TAB, IDC_SELECT_PREVIOUS_TAB and

20 // IDC_SELECT_LAST_TAB.	19 // IDC_SELECT_LAST_TAB.

21 TEST_F(BrowserCommandsTest, TabNavigationAccelerators) {	20 TEST_F(BrowserCommandsTest, TabNavigationAccelerators) {

(...skipping 139 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
161 ASSERT_EQ(3, browser()->selected_index());	160 ASSERT_EQ(3, browser()->selected_index());

162 ASSERT_EQ(url1, browser()->GetSelectedTabContents()->GetURL());	161 ASSERT_EQ(url1, browser()->GetSelectedTabContents()->GetURL());

163	162

164 // Same thing again for forward.	163 // Same thing again for forward.

165 // TODO(brettw) bug 11055: see the comment above about why we need this.	164 // TODO(brettw) bug 11055: see the comment above about why we need this.

166 CommitPendingLoad(&browser()->GetSelectedTabContents()->controller());	165 CommitPendingLoad(&browser()->GetSelectedTabContents()->controller());

167 browser()->GoForward(NEW_FOREGROUND_TAB);	166 browser()->GoForward(NEW_FOREGROUND_TAB);

168 ASSERT_EQ(4, browser()->selected_index());	167 ASSERT_EQ(4, browser()->selected_index());

169 ASSERT_EQ(url2, browser()->GetSelectedTabContents()->GetURL());	168 ASSERT_EQ(url2, browser()->GetSelectedTabContents()->GetURL());

170 }	169 }

OLD	NEW