Change default logic for OpenApplicationTab for extensions without launch URLs

Change default logic for OpenApplicationTab for extensions without launch URLs

BUG=68890
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72666

[The wrong rickcam account, 2011-01-22 00:44:10]

Please take a look.

[Andrew T Wilson (Slow), 2011-01-22 01:32:14]

LGTM with one nit.

I'd want Erik to have a chance to look at this as well before landing, though.

http://codereview.chromium.org/6259015/diff/3001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6259015/diff/3001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:625: extension_url = GURL("chrome://extensions/");
You should use chrome::kChromeUIExtensionsURL here instead.

[The wrong rickcam account, 2011-01-22 01:42:30]

I've incorporated that change.  Waiting to hear from Erik before dcommit.

http://codereview.chromium.org/6259015/diff/3001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6259015/diff/3001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:625: extension_url = GURL("chrome://extensions/");
On 2011/01/22 01:32:14, Andrew T Wilson wrote:
> You should use chrome::kChromeUIExtensionsURL here instead.

Done.

[Erik does not do reviews, 2011-01-24 16:37:25]

I'm missing a bit of context here.  How can this happen?  Apps by definition
should have a launch URL.

[Andrew T Wilson (Slow), 2011-01-24 16:49:29]

We're calling that routine for extensions as well (we provide a list of
background apps and extensions in the status tray item menu, and this is the
API we call when the user clicks on one). If we don't want to support
passing extensions to this routine, we can move this logic up to the caller
instead - that's one of the main reasons I wanted you CC'd on this review.

-atw

On Mon, Jan 24, 2011 at 8:37 AM, <erikkay@chromium.org> wrote:

> I'm missing a bit of context here.  How can this happen?  Apps by
> definition
> should have a launch URL.
>
>
> http://codereview.chromium.org/6259015/
>

[The wrong rickcam account, 2011-01-26 19:37:25]

Erik gave his LGTM via email:

From:	Erik Kay <erikkay@google.com>

It sounds like Glen and Brian don't have an objection to your original plan, so
I'll withdraw mine.  Given this, the original CL LGTM.

Erik