Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: webkit/plugins/npapi/plugin_host.cc

Issue 6259013: Update Mac plugin IME handling to match updated spec (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to trunk Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mozilla/README.chromium ('k') | webkit/plugins/npapi/webplugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_host.cc
diff --git a/webkit/plugins/npapi/plugin_host.cc b/webkit/plugins/npapi/plugin_host.cc
index 53841c342f4654b274ddf9fce4326cdfb23dbeb5..9aed03b2d44853faccb3456209aa3307a42d8666 100644
--- a/webkit/plugins/npapi/plugin_host.cc
+++ b/webkit/plugins/npapi/plugin_host.cc
@@ -840,6 +840,16 @@ NPError NPN_GetValue(NPP id, NPNVariable variable, void* value) {
rv = NPERR_NO_ERROR;
break;
}
+ case NPNVsupportsUpdatedCocoaTextInputBool: {
+ // We support the clarifications to the Cocoa IME event spec, but since
+ // IME currently only works on 10.6, only answer true there.
+ NPBool* supports_update = reinterpret_cast<NPBool*>(value);
+ int32 major, minor, bugfix;
+ base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugfix);
+ *supports_update = major > 10 || (major == 10 && minor > 5);
+ rv = NPERR_NO_ERROR;
+ break;
+ }
#endif // OS_MACOSX
case NPNVPepperExtensions:
// Available for any plugin that attempts to get it.
« no previous file with comments | « third_party/mozilla/README.chromium ('k') | webkit/plugins/npapi/webplugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698