Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 6259013: Update Mac plugin IME handling to match updated spec (Closed)

Created:
9 years, 11 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, stuartmorgan, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Update Mac plugin IME handling to match updated spec This changes IME handling per the recent NPAPI spec clarification, and adds the new bool to indicate conformance to the new model. Also: - Fixes an existing bug where the initial key down would be sent to the wrong IME system (since it happens before plugin IME starts) by having the render widget track whether a plugin is focused. - Changes ComplexTextInputPanel to match recent upstream changes. BUG=70427 TEST=None (plugins have not yet implemented Cocoa IME). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72190

Patch Set 1 #

Patch Set 2 : Fix simultaneous key press handling #

Patch Set 3 : Update mozilla README since there is now less divergence #

Patch Set 4 : Rebase to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -121 lines) Patch
M chrome/browser/renderer_host/render_widget_host.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 10 chunks +52 lines, -32 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 3 chunks +13 lines, -8 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 3 3 chunks +14 lines, -7 lines 0 comments Download
M third_party/mozilla/ComplexTextInputPanel.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mozilla/ComplexTextInputPanel.mm View 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/mozilla/README.chromium View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 3 4 chunks +9 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 8 chunks +57 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
9 years, 11 months ago (2011-01-21 19:26:55 UTC) #1
pink (ping after 24hrs)
9 years, 11 months ago (2011-01-21 21:14:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698