chrome/browser/plugin_service_browsertest.cc - Issue 6259008: When we detect a PDF with an unsupported feature, ask the user if they want t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_service_browsertest.cc

Issue 6259008: When we detect a PDF with an unsupported feature, ask the user if they want t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/pdf_unsupported_feature.cc ('K') | « chrome/browser/plugin_service.cc ('k') | chrome/browser/renderer_host/render_message_filter.h » ('j') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_service_browsertest.cc

===================================================================

--- chrome/browser/plugin_service_browsertest.cc (revision 71882)

+++ chrome/browser/plugin_service_browsertest.cc (working copy)

@@ -82,7 +82,7 @@

IN_PROC_BROWSER_TEST_F(PluginServiceTest, OpenChannelToPlugin) {

MockPluginProcessHostClient mock_client;

EXPECT_CALL(mock_client, SetPluginInfo(testing::_)).Times(1);

- plugin_service_->OpenChannelToPlugin(GURL("http://google.com/"),

+ plugin_service_->OpenChannelToPlugin(0, 0, GURL("http://google.com/"),

"audio/mp3",

&mock_client);

message_loop_.RunAllPending();

@@ -97,7 +97,7 @@

// supports all mime types.

webkit::npapi::WebPluginInfo plugin_info;

std::string plugin_mime_type;

- plugin_service_->GetFirstAllowedPluginInfo(GURL("http://google.com/"),

+ plugin_service_->GetFirstAllowedPluginInfo(0, 0, GURL("http://google.com/"),

"application/pdf",

&plugin_info,

&plugin_mime_type);