DOMUI: Fix AF CC field some more.

DOMUI: Fix AF CC field some more.
* Don't erase the first typed character when the field is empty.
* Don't allow users to select text of buttons and selects, which was causing
  the 'Add CC' button text to be selected when the user activated a list item.

BUG=70868
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72693

[arv (Not doing code reviews), 2011-01-26 19:27:35]

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
(right):

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
Why would event be undefined?

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
Please create a var for $('creditCardNumber') so that you don't have to call
getElementById 3 times here.

[James Hawkins, 2011-01-26 19:38:30]

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
(right):

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
On 2011/01/26 19:27:35, arv wrote:
> Why would event be undefined?

This method is called on overlay load w/out a parameter (to set up the initial
button state).

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
On 2011/01/26 19:27:35, arv wrote:
> Please create a var for $('creditCardNumber') so that you don't have to call
> getElementById 3 times here.

Done.

[arv (Not doing code reviews), 2011-01-26 20:00:41]

LGTM

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
(right):

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
On 2011/01/26 19:38:30, James Hawkins wrote:
> On 2011/01/26 19:27:35, arv wrote:
> > Why would event be undefined?
> 
> This method is called on overlay load w/out a parameter (to set up the initial
> button state).

Please rename the param to opt_event and document it using JSDoc.

[Ilya Sherman, 2011-01-26 20:15:04]

Logic changes LGTM, thanks.

[James Hawkins, 2011-01-26 21:31:36]

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
(right):

http://codereview.chromium.org/6258022/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autofill_edit_creditcard_overlay.js:113: event
&& event.target == $('creditCardNumber') &&
On 2011/01/26 20:00:41, arv wrote:
> On 2011/01/26 19:38:30, James Hawkins wrote:
> > On 2011/01/26 19:27:35, arv wrote:
> > > Why would event be undefined?
> > 
> > This method is called on overlay load w/out a parameter (to set up the
initial
> > button state).
> 
> Please rename the param to opt_event and document it using JSDoc.

Done.