Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6258017: Mac: Never have a space between @property and ( (Closed)

Created:
9 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, James Hawkins, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Mac: Never have a space between @property and ( CL created by: cd chrome find . -name '*.h' | xargs sed -i -e 's/@property /@property/' Also manually move @property blocks so that they are right after the ivar blocks, as suggested by the style guide. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72355

Patch Set 1 #

Total comments: 13

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -151 lines) Patch
M chrome/browser/autofill/autofill_address_model_mac.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/autofill/autofill_address_sheet_controller_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_credit_card_model_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_image.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/element_applescript.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bug_report_window_controller.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/clear_browsing_data_controller.h View 1 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/draggable_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_prompt_controller.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_button_cell.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/importer/import_progress_dialog.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/options/cookies_window_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/options/keyword_editor_cocoa_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/options/preferences_window_controller.h View 1 2 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_test_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_view_picker_table.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_resizer_pong.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
Thanks. Got a few manual things for you, too, while you're doing this. http://codereview.chromium.org/6258017/diff/1/chrome/browser/ui/cocoa/bug_report_window_controller.h File ...
9 years, 11 months ago (2011-01-24 18:03:57 UTC) #1
Nico
http://codereview.chromium.org/6258017/diff/1/chrome/browser/ui/cocoa/bug_report_window_controller.h File chrome/browser/ui/cocoa/bug_report_window_controller.h (right): http://codereview.chromium.org/6258017/diff/1/chrome/browser/ui/cocoa/bug_report_window_controller.h#newcode101 chrome/browser/ui/cocoa/bug_report_window_controller.h:101: // Properties for bindings. On 2011/01/24 18:03:57, rsesek wrote: ...
9 years, 11 months ago (2011-01-24 18:13:25 UTC) #2
Robert Sesek
9 years, 11 months ago (2011-01-24 18:18:29 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698