Remove wstring from autocomplete....

chrome/browser/automation/testing_automation_provider.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #define CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
@@ skipping 120 matching lines @@
   void GetTabIndex(int handle, int* tabstrip_index);
   void GetTabURL(int handle, bool* success, GURL* url);
   void GetShelfVisibility(int handle, bool* visible);
   void IsFullscreen(int handle, bool* is_fullscreen);
   void GetFullscreenBubbleVisibility(int handle, bool* is_visible);
   void GetAutocompleteEditForBrowser(int browser_handle, bool* success,
                                      int* autocomplete_edit_handle);
 
   // Retrieves the visible text from the autocomplete edit.
   void GetAutocompleteEditText(int autocomplete_edit_handle,
-                               bool* success, std::wstring* text);
+                               bool* success, string16* text);
 
   // Sets the visible text from the autocomplete edit.
   void SetAutocompleteEditText(int autocomplete_edit_handle,
-                               const std::wstring& text,
+                               const string16& text,
                                bool* success);
 
   // Retrieves if a query to an autocomplete provider is in progress.
   void AutocompleteEditIsQueryInProgress(int autocomplete_edit_handle,
                                          bool* success,
                                          bool* query_in_progress);
 
   // Retrieves the individual autocomplete matches displayed by the popup.
   void AutocompleteEditGetMatches(int autocomplete_edit_handle,
                                   bool* success,
@@ skipping 525 matching lines @@
   // The opposite of the above: translates from the internal data structure
   // for profiles and credit cards to a ListValue of DictionaryValues. The
   // caller owns the returned object.
   static ListValue* GetListFromAutoFillProfiles(
       const std::vector<AutoFillProfile*>& autofill_profiles);
   static ListValue* GetListFromCreditCards(
       const std::vector<CreditCard*>& credit_cards);
 
   // Return the map from the internal data representation to the string value
   // of auto fill fields and credit card fields.
-  static std::map<AutoFillFieldType, std::wstring>
+  static std::map<AutoFillFieldType, std::string>

[evanm, 2011/01/24 19:14:14]

Why did we use UTF-8 here?  You can autofill an e.g. non-ASCII first name.  This
should have been string16.  :(

I know it's not your fault, but perhaps we should use string16 here and convert
to UTF-8 at the last second to avoid bad API creep.

[Avi (use Gerrit), 2011/01/24 19:46:42]

That's not what this map is for. This map does not contain any user-provided
autofill data. It contains autofill keys. Please see the implementations of
GetAutoFillFieldToStringMap and GetCreditCardFieldToStringMap to see how they're
used.

       GetAutoFillFieldToStringMap();
-  static std::map<AutoFillFieldType, std::wstring>
+  static std::map<AutoFillFieldType, std::string>
       GetCreditCardFieldToStringMap();
 
   // Get a list of active HTML5 notifications.
   // Uses the JSON interface for input/output.
   void GetActiveNotifications(Browser* browser,
                               DictionaryValue* args,
                               IPC::Message* reply_message);
 
   // Close an active HTML5 notification.
   // Uses the JSON interface for input/output.
@@ skipping 102 matching lines @@
   // Used to import settings from browser profiles.
   scoped_refptr<ImporterHost> importer_host_;
 
   // The stored data for the ImportSettings operation.
   ImportSettingsData import_settings_data_;
 
   DISALLOW_COPY_AND_ASSIGN(TestingAutomationProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_