Issue 6258010: Fix my (??) stupid typo in memcheck_analyze which stupid python didn't caught...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6258010: Fix my (??) stupid typo in memcheck_analyze which stupid python didn't caught... (Closed)

Created:
9 years, 11 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Evgeniy Stepanov

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix my (??) stupid typo in memcheck_analyze which stupid python didn't caught. As a result, memcheck_analyze was waiting for dead Valgrind processes for 3 extra minutes. D'oh. BUG=17453, 44545 TEST=trybots, experiments by eugenis@ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72119

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/memcheck_analyze.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 11 months ago (2011-01-21 09:01:23 UTC) #3

LGTM

On Fri, Jan 21, 2011 at 12:10 AM,  <thestig@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/6258010/
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages