Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 6258007: A workaround for Bug 36939.... (Closed)

Created:
9 years, 11 months ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

A workaround for Bug 36939. This change just adds a boundary check to prevent |minimize_button_offset| from exceeding the frame width and to mitigate its pain. (This is not a real fix since the frame width is not equal to the offset to the minimize button of Windows. Nevertheless, it may be a good idea that a whole tab strip is always rendered inside of its parent frame.) BUG=36939 TEST=run chrome on Win7 PC whose DPI is 144, open 20 tabs, and verify we can see a '+' (newtab) button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
9 years, 11 months ago (2011-01-19 10:39:06 UTC) #1
Ben Goodger (Google)
9 years, 11 months ago (2011-01-19 15:23:36 UTC) #2
Good enough. The only difference is potentially a few pixels for shadow. LGTM.

Powered by Google App Engine
This is Rietveld 408576698