Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: src/messages.js

Issue 6258004: Fix name of the toString method on error objects. Bug caught by layout tests.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 $Error.prototype.message = ''; 1007 $Error.prototype.message = '';
1008 1008
1009 function errorToString() { 1009 function errorToString() {
1010 var type = this.type; 1010 var type = this.type;
1011 if (type && !this.hasOwnProperty("message")) { 1011 if (type && !this.hasOwnProperty("message")) {
1012 return this.name + ": " + FormatMessage({ type: type, args: this.arguments } ); 1012 return this.name + ": " + FormatMessage({ type: type, args: this.arguments } );
1013 } 1013 }
1014 var message = this.hasOwnProperty("message") ? (": " + this.message) : ""; 1014 var message = this.hasOwnProperty("message") ? (": " + this.message) : "";
1015 return this.name + message; 1015 return this.name + message;
1016 } 1016 }
1017
1018 %FunctionSetName(errorToString, 'toString');
1017 %SetProperty($Error.prototype, 'toString', errorToString, DONT_ENUM); 1019 %SetProperty($Error.prototype, 'toString', errorToString, DONT_ENUM);
1018 1020
1019 1021
1020 // Boilerplate for exceptions for stack overflows. Used from 1022 // Boilerplate for exceptions for stack overflows. Used from
1021 // Top::StackOverflow(). 1023 // Top::StackOverflow().
1022 const kStackOverflowBoilerplate = MakeRangeError('stack_overflow', []); 1024 const kStackOverflowBoilerplate = MakeRangeError('stack_overflow', []);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698