Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 6257018: Import firmware compiler flags (Closed)

Created:
9 years, 11 months ago by Che-Liang Chiou
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Import firmware compiler flags If passed into Makefile, compiler flags for firmware (so far CC and CFLAGS) will override old values to make sure that the compiled vboot_reference library has calling convention and etc. compatible with the firmware. See also CL:6355014 BUG=None TEST=See the CL for related ebuilds Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=440ad51

Patch Set 1 #

Total comments: 2

Patch Set 2 : reorder CFLAGS assignments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M Makefile View 1 1 chunk +20 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Che-Liang Chiou
9 years, 11 months ago (2011-01-26 07:56:54 UTC) #1
Tom Wai-Hong Tam
LGTM
9 years, 11 months ago (2011-01-26 10:08:43 UTC) #2
robotboy
http://codereview.chromium.org/6257018/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6257018/diff/1/Makefile#newcode20 Makefile:20: endif Won't these CFLAGS be overridden by the include ...
9 years, 11 months ago (2011-01-26 19:43:20 UTC) #3
Che-Liang Chiou
Thanks for comments. Please check out the new patchset. http://codereview.chromium.org/6257018/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/6257018/diff/1/Makefile#newcode20 Makefile:20: ...
9 years, 11 months ago (2011-01-27 02:12:53 UTC) #4
robotboy
9 years, 11 months ago (2011-01-27 02:18:30 UTC) #5
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698