Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6257017: views: Move standard_layout.h into the layout directory. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

views: Move standard_layout.h into the layout directory. Also rename it to layout_constants, as now this file just contains constants. The grid_layout files will be moved later. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72709

Patch Set 1 #

Patch Set 2 : include grid-layout.h #

Patch Set 3 : fix chromeos #

Patch Set 4 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -96 lines) Patch
M chrome/browser/chromeos/login/captcha_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/network_selection_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/internet_page_view.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/settings_page_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/options/settings_page_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/system_page_view.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/input_window_dialog_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill_profiles_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmark_bubble_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmark_editor_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/clear_browsing_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/clear_browsing_data_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/clear_data_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/clear_server_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_message_box_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/database_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/default_search_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_prompt2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/generic_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importer_lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importing_progress_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/indexed_db_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyword_editor_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/local_storage_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/local_storage_set_item_info_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/advanced_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/advanced_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/content_filter_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/content_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/cookie_filter_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/cookies_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/exception_editor_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/exceptions_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/exceptions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/fonts_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/general_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/languages_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/managed_prefs_banner_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/options_group_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/passwords_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/plugin_filter_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/simple_content_exceptions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/url_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/message_box_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M views/grid_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
A + views/layout/layout_constants.h View 2 chunks +3 lines, -6 lines 0 comments Download
M views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M views/window/dialog_client_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-26 03:22:28 UTC) #1
sky
9 years, 11 months ago (2011-01-26 16:50:53 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698