Adjustments to bookmark bar folder menu placement issues....

Adjustments to bookmark bar folder menu placement issues.
1) Sub-menus should expose as much as possible without needing to be scrolled up when the dock is showing at the bottom.
2) Fix how menu bottom is misplaced and window is foreshortened when that last scroll-up is performed (for a menu which fits on the screen after being completely scrolled up).
3) Align the right edge of the menu with the right edge of the bookmark bar button from which it springs.
4) Tighten up the menu item spacing.

BUG=54701, 69418, 69346, 59057
TEST=1) Place window near bottom of screen with dock showing. Pop up a folder menu (one which will completely fit on the screen after being fully scrolled up) and scroll fully up. Verify that the bottom it properly placed and all folder contents are shown. Verify that the menu right edge is aligned with the right edge of the button.
2) Have a bookmark folder menu with a submenu near the bottom. Pop up the folder menu and then the submenu. Verify all of the submenu appears.
3) All BookmarkBarFolderControllerTests menu unit tests pass.
4) All BookmarkBarFolderControllerMenuTests menu unit tests pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71889

[mrossetti, 2011-01-19 20:17:58]

Thanks maf!

[mafv, 2011-01-19 22:39:39]

LGTM except for some minor quibbles about indentation.

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:476:
newWindowTopLeft = NSMakePoint(buttonBottomLeftInScreen.x +
Indentation in this function looks weird. I see what  you're aiming to do
(treating each function argument as a block, and aligning those blocks at the
open paren), but I find it confusing to look at.

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right):

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:238:
(NSHeight(imageRect) / 2.0) + kArrowOffset);
It may just be the codereview system, but the indentation looks off.

[mrossetti, 2011-01-20 01:41:42]

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:476:
newWindowTopLeft = NSMakePoint(buttonBottomLeftInScreen.x +
On 2011/01/19 22:39:39, mafv wrote:
> Indentation in this function looks weird. I see what  you're aiming to do
> (treating each function argument as a block, and aligning those blocks at the
> open paren), but I find it confusing to look at.  

Done.

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right):

http://codereview.chromium.org/6257005/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:238:
(NSHeight(imageRect) / 2.0) + kArrowOffset);
On 2011/01/19 22:39:39, mafv wrote:
> It may just be the codereview system, but the indentation looks off.

Done.