Fix videos stopping playing. An invalidate doesn't always lead to a paint (i...

chrome/plugin/webplugin_proxy.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/plugin/webplugin_proxy.h"
 
 #include "base/gfx/bitmap_header.h"
 #include "base/gfx/platform_device_win.h"
 #include "base/scoped_handle.h"
 #include "base/shared_memory.h"
@@ skipping 66 matching lines @@
   Send(new PluginHostMsg_CancelResource(route_id_, id));
   resource_clients_.erase(id);
 }
 
 void WebPluginProxy::Invalidate() {
   gfx::Rect rect(0, 0, delegate_->rect().width(), delegate_->rect().height());
   InvalidateRect(rect);
 }
 
 void WebPluginProxy::InvalidateRect(const gfx::Rect& rect) {
-  // Ignore NPN_InvalidateRect calls with empty rects.
-  if (rect.IsEmpty())
+  // Ignore NPN_InvalidateRect calls with empty rects.  Also don't send an
+  // invalidate if it's outside the clipping region, since if we did it won't
+  // lead to a paint and we'll be stuck waiting forever for a DidPaint response.
+  if (rect.IsEmpty() || !delegate_->clip_rect().Intersects(rect))
     return;
 
   damaged_rect_ = damaged_rect_.Union(rect);
   // Only send a single InvalidateRect message at a time.  From DidPaint we
   // will dispatch an additional InvalidateRect message if necessary.
   if (!waiting_for_paint_) {
     waiting_for_paint_ = true;
     // Paint to the plugin bitmap and let the renderer know so it can update
     // its backing store.
     Paint(damaged_rect_);
@@ skipping 267 matching lines @@
 void WebPluginProxy::InitiateHTTPRangeRequest(const char* url,
                                               const char* range_info,
                                               void* existing_stream,
                                               bool notify_needed,
                                               HANDLE notify_data) {
 
   Send(new PluginHostMsg_InitiateHTTPRangeRequest(route_id_, url,
                                                   range_info, existing_stream,
                                                   notify_needed, notify_data));
 }