Issue 6256004: views: Implement NativeTableGtk::RemoveColumn method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6256004: views: Implement NativeTableGtk::RemoveColumn method. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, oshima, Evan Martin

CC:
chromium-reviews, Evan Stade

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Implement NativeTableGtk::RemoveColumn method. Also fix the following error when we try to get the width of column that does not exist anymore. (views_examples:3921): Gtk-CRITICAL **: gtk_tree_view_column_get_width: assertion `GTK_IS_TREE_VIEW_COLUMN (tree_column)' failed BUG=None TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples out/Debug/views_examples, go to the table tab. Now clicking in one of the checkboxes, the corresponded column should be removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71786

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	views/controls/table/native_table_gtk.cc	View		1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages