Issue 6255012: Fix minilayout to work with new kernel ebuild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6255012: Fix minilayout to work with new kernel ebuild (Closed)

Created:
9 years, 11 months ago by anush

Modified:
9 years, 7 months ago

Reviewers:
zbehan, Mandeep Singh Baines, marcheu

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush

Base URL:
http://git.chromium.org/git/chromiumos-overlay.git@master

Visibility:
Public.

Description

Fix minilayout to work with new kernel ebuild Change-Id: I15f74b3dfca463b14cde75599293106c9d11815b BUG=n0ne TEST=emerge-board chromeos-kernel Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4e1b9e3

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zbehan

9 years, 11 months ago (2011-01-22 19:53:28 UTC) #2

LGTM

On Sat, Jan 22, 2011 at 8:52 PM, <anush@chromium.org> wrote:

> Reviewers: zbehan, Mandeep Singh Baines, marcheu,
>
> Description:
> Fix minilayout to work with new kernel ebuild
>
> Change-Id: I15f74b3dfca463b14cde75599293106c9d11815b
>
> BUG=n0ne
> TEST=emerge-board chromeos-kernel
>
> Please review this at http://codereview.chromium.org/6255012/
>
> SVN Base: http://git.chromium.org/git/chromiumos-overlay.git@master
>
> Affected files:
>  M sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
>
>
> Index: sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
> diff --git a/sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
> b/sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
> index
>
85b2f2a53b5eaa21f0edcce18cdf0be2da68f836..ba3d9f44ce5997c51808301765d3cbd0aad4a632
> 100644
> --- a/sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
> +++ b/sys-kernel/chromeos-kernel/chromeos-kernel-0.0.1-r131.ebuild
> @@ -34,6 +34,7 @@ else
>        fi
>  fi
>
> +CROS_WORKON_PROJECT="kernel"
>  # TODO(jglasgow) Need to fix DEPS file to get rid of "files"
>  CROS_WORKON_LOCALNAME="../third_party/kernel/files"
>
>
>
>

Expand Messages | Collapse Messages