Issue 6254022: Don't wipe cache dir, only its contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6254022: Don't wipe cache dir, only its contents. (Closed)

Created:
9 years, 11 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

Don't wipe cache dir, only its contents. This way there is no race condition to create this dir. Change-Id: I6cbce000f15f21b844d44957da7ae9273cdf85fa BUG=chromium-os:10723 TEST=Ran it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6b8c374

Patch Set 1 #

Patch Set 2 : Fix cache #

Total comments: 1

Patch Set 3 : :wq #

Patch Set 4 : Sanity check #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
	M	devserver.py	View	1 2	1 chunk	+17 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgarrett

http://codereview.chromium.org/6254022/diff/3001/devserver.py File devserver.py (right): http://codereview.chromium.org/6254022/diff/3001/devserver.py#newcode170 devserver.py:170: if os.system('rm -rf %s/*' % cache_dir) != 0: I ...

9 years, 11 months ago (2011-01-27 22:43:38 UTC) #2

dgarrett

9 years, 11 months ago (2011-01-27 22:54:31 UTC) #4

Nevermind. I thought "rm -rf /tmp/fuzzy/*" would either give an error, or
wipe out /tmp/fuzzy. Doesn't seem to be the case, so never mind. Hum... I
might still be prone to remove the directory and let it be recreated to fix
permission/ownership problems or whatever, but that's a minor suggestion.

On Thu, Jan 27, 2011 at 2:49 PM, <sosa@chromium.org> wrote:

> how's this?
>
>
> http://codereview.chromium.org/6254022/
>

-- 
Don

Expand Messages | Collapse Messages