Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3634)

Unified Diff: chrome/common/render_messages.cc

Issue 6253017: Pepper/Flapper: First pass at context menu implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: PPB_Flash: 4 -> 5 Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages.cc
diff --git a/chrome/common/render_messages.cc b/chrome/common/render_messages.cc
index d872fecb77cea6ca740754b370d848e192bf96b3..ca9973cd2cb1437f584c98b02beda74f030befb9 100644
--- a/chrome/common/render_messages.cc
+++ b/chrome/common/render_messages.cc
@@ -55,12 +55,18 @@ struct ParamTraits<WebMenuItem::Type> {
case WebMenuItem::OPTION:
type = "OPTION";
break;
+ case WebMenuItem::CHECKABLE_OPTION:
+ type = "CHECKABLE_OPTION";
+ break;
case WebMenuItem::GROUP:
type = "GROUP";
break;
case WebMenuItem::SEPARATOR:
type = "SEPARATOR";
break;
+ case WebMenuItem::SUBMENU:
+ type = "SUBMENU";
+ break;
default:
type = "UNKNOWN";
break;
@@ -78,9 +84,9 @@ void ParamTraits<FontDescriptor>::Write(Message* m, const param_type& p) {
bool ParamTraits<FontDescriptor>::Read(const Message* m,
void** iter,
param_type* p) {
- return(
+ return
ReadParam(m, iter, &p->font_name) &&
- ReadParam(m, iter, &p->font_point_size));
+ ReadParam(m, iter, &p->font_point_size);
}
void ParamTraits<FontDescriptor>::Log(const param_type& p, std::string* l) {
@@ -88,6 +94,31 @@ void ParamTraits<FontDescriptor>::Log(const param_type& p, std::string* l) {
}
#endif
+void ParamTraits<webkit_glue::CustomContextMenuContext>::Write(
+ Message* m,
+ const param_type& p) {
+ WriteParam(m, p.is_pepper_menu);
+ WriteParam(m, p.request_id);
+}
+
+bool ParamTraits<webkit_glue::CustomContextMenuContext>::Read(const Message* m,
+ void** iter,
brettw 2011/01/29 00:56:52 Fix indentation.
viettrungluu 2011/01/29 21:49:14 Done.
+ param_type* p) {
+ return
+ ReadParam(m, iter, &p->is_pepper_menu) &&
+ ReadParam(m, iter, &p->request_id);
+}
+
+void ParamTraits<webkit_glue::CustomContextMenuContext>::Log(
+ const param_type& p,
+ std::string* l) {
+ l->append("(");
+ LogParam(p.is_pepper_menu, l);
+ l->append(", ");
+ LogParam(p.request_id, l);
+ l->append(")");
+}
+
void ParamTraits<ContextMenuParams>::Write(Message* m, const param_type& p) {
WriteParam(m, p.media_type);
WriteParam(m, p.x);
@@ -112,6 +143,7 @@ void ParamTraits<ContextMenuParams>::Write(Message* m, const param_type& p) {
WriteParam(m, p.edit_flags);
WriteParam(m, p.security_info);
WriteParam(m, p.frame_charset);
+ WriteParam(m, p.custom_context);
WriteParam(m, p.custom_items);
}
@@ -141,6 +173,7 @@ bool ParamTraits<ContextMenuParams>::Read(const Message* m, void** iter,
ReadParam(m, iter, &p->edit_flags) &&
ReadParam(m, iter, &p->security_info) &&
ReadParam(m, iter, &p->frame_charset) &&
+ ReadParam(m, iter, &p->custom_context) &&
ReadParam(m, iter, &p->custom_items);
}
@@ -742,6 +775,7 @@ void ParamTraits<WebMenuItem>::Write(Message* m, const param_type& p) {
WriteParam(m, p.enabled);
WriteParam(m, p.checked);
WriteParam(m, p.action);
+ WriteParam(m, p.submenu);
}
bool ParamTraits<WebMenuItem>::Read(const Message* m,
@@ -752,7 +786,8 @@ bool ParamTraits<WebMenuItem>::Read(const Message* m,
ReadParam(m, iter, &p->type) &&
ReadParam(m, iter, &p->enabled) &&
ReadParam(m, iter, &p->checked) &&
- ReadParam(m, iter, &p->action);
+ ReadParam(m, iter, &p->action) &&
+ ReadParam(m, iter, &p->submenu);
}
void ParamTraits<WebMenuItem>::Log(const param_type& p, std::string* l) {
@@ -766,6 +801,8 @@ void ParamTraits<WebMenuItem>::Log(const param_type& p, std::string* l) {
LogParam(p.checked, l);
l->append(", ");
LogParam(p.action, l);
+ l->append(", ");
+ LogParam(p.submenu, l);
l->append(")");
}

Powered by Google App Engine
This is Rietveld 408576698