Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 6253005: touch: Gesture manager receives the touch-sequence status. (Closed)

Created:
9 years, 11 months ago by sadrul
Modified:
9 years, 6 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

touch: Gesture manager receives the touch-sequence status. OnTouchEvent now returns the status of the touch sequence, instead of a simple bool. The gesture manager can presumably make a better decision if this information is available to it. For more details: http://codereview.chromium.org/6347002/ BUG=none TEST=ViewTest.TouchEvent Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71824

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update unittest for gesture manager. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M views/touchui/gesture_manager.h View 2 chunks +4 lines, -6 lines 0 comments Download
M views/touchui/gesture_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M views/view_unittest.cc View 1 4 chunks +17 lines, -4 lines 0 comments Download
M views/widget/root_view.cc View 5 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
http://codereview.chromium.org/6253005/diff/1/views/widget/root_view.cc File views/widget/root_view.cc (right): http://codereview.chromium.org/6253005/diff/1/views/widget/root_view.cc#newcode318 views/widget/root_view.cc:318: gesture_manager_->ProcessTouchEventForGesture(e, this, status); Should the status fall through, or ...
9 years, 11 months ago (2011-01-18 19:33:30 UTC) #1
rjkroege
was there any test updating needed for this? http://codereview.chromium.org/6253005/diff/1/views/widget/root_view.cc File views/widget/root_view.cc (right): http://codereview.chromium.org/6253005/diff/1/views/widget/root_view.cc#newcode318 views/widget/root_view.cc:318: gesture_manager_->ProcessTouchEventForGesture(e, ...
9 years, 11 months ago (2011-01-18 20:01:27 UTC) #2
rjkroege
LGTM
9 years, 11 months ago (2011-01-18 20:01:45 UTC) #3
sadrul
On 2011/01/18 20:01:27, rjkroege wrote: > was there any test updating needed for this? > ...
9 years, 11 months ago (2011-01-18 20:39:19 UTC) #4
sky
LGTM
9 years, 11 months ago (2011-01-18 22:59:40 UTC) #5
rjkroege
9 years, 11 months ago (2011-01-19 19:28:29 UTC) #6
SLGTM

Powered by Google App Engine
This is Rietveld 408576698